lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yonik Seeley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-3535) Add block support for XMLLoader
Date Wed, 13 Jun 2012 14:39:44 GMT

    [ https://issues.apache.org/jira/browse/SOLR-3535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294500#comment-13294500
] 

Yonik Seeley commented on SOLR-3535:
------------------------------------

bq. At first blush, I think we'd want a single SolrInputDocument passing through the update
processor chain AddUpdateCommand, and that document would be nested.  You'd need to keep that
entire nested structure as a single unit for as long as possible I think.

Yes, exactly.  That also gives the most power... update processors that care about the structure
of the nested documents can get to it.

bq. But of course there are cons.... update processors would need to coded to handle nested
documents explicitly,

The necessity to treat multiple docs as a single update introduce complexity into the update
processor chain regardless.  If not a nested SolrInputDocument, then we'd need to pass along
a List<SolrInputDocument> to keep them together anyway, and document mutating processors
would need to change to iterate over this list.  For simple mutating processors, we can have
a utility class that visits each document.

Of course the biggest benefit of treating as a single document means that all the solr cloud
stuff we've done (transaction log recovery, peer sync, update forwarding, per-doc replication,
etc, should all just work)
                
> Add block support for XMLLoader
> -------------------------------
>
>                 Key: SOLR-3535
>                 URL: https://issues.apache.org/jira/browse/SOLR-3535
>             Project: Solr
>          Issue Type: Sub-task
>          Components: update
>    Affects Versions: 4.1, 5.0
>            Reporter: Mikhail Khludnev
>            Priority: Minor
>         Attachments: SOLR-3535.patch
>
>
> I'd like to add the following update xml message:
> <add-block>
>     <doc>....</doc>
>     <doc>....</doc>
> </add-block>
> out of scope for now: 
> * other update formats
> * update log support (NRT), should not be a big deal
> * overwrite feature support for block updates - it's more complicated, I'll tell you
why
> Alt
> * wdyt about adding attribute to the current tag {pre}<add block="true">{pre} 
> * or we can establish RunBlockUpdateProcessor which treat every <add> ....</add>
as a block.
> *Test is included!!*
> How you'd suggest to improve the patch?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message