lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mikhail Khludnev (JIRA)" <>
Subject [jira] [Commented] (SOLR-3535) Add block support for XMLLoader
Date Wed, 13 Jun 2012 20:47:42 GMT


Mikhail Khludnev commented on SOLR-3535:

assuming that at the hight level of abstraction app deal with multiple levels of nesting with
multiple relations: model has several SKUs/UPCs and several Discounts with regional and temporal
* I don't feel that this rich model is covered with single level parent-child well.
* Don't you want to provide two ways to deal with relation content: index time block join
and traditional join/grouping with FK fields and denormalization?
* PK field is a blocker for transparent handling scoped docs by the current processors. i.e.
I don't think it's mandatory to provide PK field for every child document (most time it's
useless and redundant info)
* field update processors can work wrong if the same field name is present in several scopes
- name clash between different relations/scopes 
* why new api/property is necessary? is solrInputDoc.addField("skus", new Object[]{sku1, sku2,
sku3}) not enough?

I propose the following design: 
* there is a *pre*processors chain which deal with scoped documents and flatten them - there
should be two of them: block-join (bjq counterpart); denormalizer (grouping counterpart);
fk-copier for query-time join;   
* update processors can handle AddUpdateCommand and AddBlockCommand as well (kind of default
loop behaviour can be supplied in abstract class)
* for distributed processor AddBlockCommand should have PK - it's preprocessors' duty
> Add block support for XMLLoader
> -------------------------------
>                 Key: SOLR-3535
>                 URL:
>             Project: Solr
>          Issue Type: Sub-task
>          Components: update
>    Affects Versions: 4.1, 5.0
>            Reporter: Mikhail Khludnev
>            Priority: Minor
>         Attachments: SOLR-3535.patch
> I'd like to add the following update xml message:
> <add-block>
>     <doc>....</doc>
>     <doc>....</doc>
> </add-block>
> out of scope for now: 
> * other update formats
> * update log support (NRT), should not be a big deal
> * overwrite feature support for block updates - it's more complicated, I'll tell you
> Alt
> * wdyt about adding attribute to the current tag {pre}<add block="true">{pre} 
> * or we can establish RunBlockUpdateProcessor which treat every <add> ....</add>
as a block.
> *Test is included!!*
> How you'd suggest to improve the patch?

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message