lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-2724) Deprecate defaultSearchField and defaultOperator defined in schema.xml
Date Fri, 15 Jun 2012 14:00:51 GMT

    [ https://issues.apache.org/jira/browse/SOLR-2724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13295666#comment-13295666
] 

David Smiley commented on SOLR-2724:
------------------------------------

bq. David: looking back at the mailing list ~ 28/Mar/12 it's not clear what exactly was the
problem that required reverting at the time ... where the test failures even caused by this
specific issue, or something else that you committed right around the same time?

That was in relation to another issue committed immediately before or after this issue, and
so to be safe this issue was reverted as it was unclear from whoever did the reverting what
was the cause of the problem.  I am more diligent about running all tests before committing
now :-}

bq. Given that we've already created the 4x branch and started pushing towards Alpha, i would
at least move forward with making sure trunk & 4x are on parity with 3.6 in terms of the
changes to the example and the log/error messages.

Gladly. I have been awaiting further input.  I'll post a patch.

RE removal of support for defaultSearchField: I may have long ago recommended removing support
for defaultSearchField (and default query operator) in the code but I've long given up on
that.  It seems once something is in Solr, it can't ever be removed, only discouraged/deprecated.
 I hope I'm wrong.
                
> Deprecate defaultSearchField and defaultOperator defined in schema.xml
> ----------------------------------------------------------------------
>
>                 Key: SOLR-2724
>                 URL: https://issues.apache.org/jira/browse/SOLR-2724
>             Project: Solr
>          Issue Type: Improvement
>          Components: Schema and Analysis, search
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Minor
>             Fix For: 3.6, 4.0
>
>         Attachments: SOLR-2724_deprecateDefaultSearchField_and_defaultOperator.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> I've always been surprised to see the <defaultSearchField> element and <solrQueryParser
defaultOperator="OR"/> defined in the schema.xml file since the first time I saw them.
 They just seem out of place to me since they are more query parser related than schema related.
But not only are they misplaced, I feel they shouldn't exist. For query parsers, we already
have a "df" parameter that works just fine, and explicit field references. And the default
lucene query operator should stay at OR -- if a particular query wants different behavior
then use q.op or simply use "OR".
> <similarity> Seems like something better placed in solrconfig.xml than in the schema.

> In my opinion, defaultSearchField and defaultOperator configuration elements should be
deprecated in Solr 3.x and removed in Solr 4.  And <similarity> should move to solrconfig.xml.
I am willing to do it, provided there is consensus on it of course.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message