lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <>
Subject [jira] [Commented] (LUCENE-4156) Improve implementation of DirectoryTaxonomyWriter.getSize()
Date Wed, 20 Jun 2012 07:23:42 GMT


Shai Erera commented on LUCENE-4156:

I've been thinking about it when I fixed it ... eventually I chose this way because if we'll
ever need to change getSize to call writer.maxDoc() again, or implement otherwise for correctness,
getParent will benefit from it too. I don't know if it's critical though that there's a method
call - is that what bothers you?
> Improve implementation of DirectoryTaxonomyWriter.getSize()
> -----------------------------------------------------------
>                 Key: LUCENE-4156
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: modules/facet
>            Reporter: Sivan Yogev
>            Assignee: Shai Erera
>            Priority: Minor
>         Attachments: LUCENE-4156.patch
> Current implementation of DirectoryTaxonomyWriter.getSize() is synchrionized and invokes
indexWriter.maxDoc(), both harming performance.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message