lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SOLR-731) CoreDescriptor.getCoreContainer should not be public
Date Thu, 14 Jun 2012 23:12:42 GMT

     [ https://issues.apache.org/jira/browse/SOLR-731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Hoss Man updated SOLR-731:
--------------------------

    Fix Version/s:     (was: 4.0)

Removing fix version since this issue hasn't gotten much attention lately and doesn't appear
to be a priority for anyone for 4.0.  

As always: if someone wants to take on this work they are welcome to do so at any time and
the target release can be revisited

In particular: i note that SolreCore.getCoreDescriptor and CoreDescriptor.getCoreContainer
both seems to be fairly widely used now throughout the code base, so it's not clear to be
that the intent/belief stated in this issue is still valid.
                
> CoreDescriptor.getCoreContainer should not be public
> ----------------------------------------------------
>
>                 Key: SOLR-731
>                 URL: https://issues.apache.org/jira/browse/SOLR-731
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 1.3
>            Reporter: Henri Biestro
>         Attachments: solr-731.patch
>
>
> For the very same reasons that CoreDescriptor.getCoreProperties did not need to be public
(aka SOLR-724)
> It also means the CoreDescriptor ctor should not need a CoreContainer
> The CoreDescriptor is only meant to be describing a "to-be created SolrCore".
> However, we need access to the CoreContainer from the SolrCore now that we are guaranteed
the CoreContainer always exists.
> This is also a natural consequence of SOLR-647 now that the CoreContainer is not a map
of CoreDescriptor but a map of SolrCore.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message