lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Male (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (LUCENE-4166) TwoDoublesStrategy is broken for Circles
Date Thu, 28 Jun 2012 03:01:45 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-4166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Chris Male resolved LUCENE-4166.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 5.0
                   4.0
         Assignee: Chris Male

Fixed, but we really need to look at this Strategy closely in another issue.
                
> TwoDoublesStrategy is broken for Circles
> ----------------------------------------
>
>                 Key: LUCENE-4166
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4166
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: modules/spatial
>            Reporter: Chris Male
>            Assignee: Chris Male
>            Priority: Critical
>             Fix For: 4.0, 5.0
>
>         Attachments: LUCENE-4166.patch
>
>
> TwoDoublesStrategy supports finding Documents that are within a Circle, yet it is impossible
to provide one due to the following code found at the start of TwoDoublesStrategy.makeQuery():
> {code}
> Shape shape = args.getShape();
>     if (!(shape instanceof Rectangle)) {
>       throw new InvalidShapeException("A rectangle is the only supported shape (so far),
not "+shape.getClass());//TODO
>     }
>     Rectangle bbox = (Rectangle) shape;
> {code}
> I think instead the code which handles Circles should ask for the bounding box of the
Shape and uses that instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message