lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (LUCENE-4115) JAR resolution/ cleanup should be done automatically for ant clean/ eclipse/ resolve.
Date Sat, 09 Jun 2012 12:48:42 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292327#comment-13292327
] 

Uwe Schindler edited comment on LUCENE-4115 at 6/9/12 12:48 PM:
----------------------------------------------------------------

bq. I know why the jars are locked - it's because junit4-ant* is taskdef'ed from ant and url
jar loader will keep it open. Makes sense. A workaround is to ignore failed deletes (I don't
see a cleaner solution other than the one mentioned above – construct the classpath from
ivy cache directly).

I thought all taskdefs are using ivy:cachepath? I changed (or I hope to have changed) at least
all those everywhere. Everything ANT needs to build with custom tasks should come from ivy
directly. Those JARs never need to be in any binary distribution.
                
      was (Author: thetaphi):
    bq. I know why the jars are locked - it's because junit4-ant* is taskdef'ed from ant and
url jar loader will keep it open. Makes sense. A workaround is to ignore failed deletes (I
don't see a cleaner solution other than the one mentioned above – construct the classpath
from ivy cache directly).

I thought all taskdefs are using ivy:cachepath? I changed at least all those everywhere. Everything
ANT needs to build with custom tasks should come from ivy directly. Those JARs never need
to be in any binary distribution.
                  
> JAR resolution/ cleanup should be done automatically for ant clean/ eclipse/ resolve.
> -------------------------------------------------------------------------------------
>
>                 Key: LUCENE-4115
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4115
>             Project: Lucene - Java
>          Issue Type: Task
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Trivial
>             Fix For: 4.0, 5.0
>
>         Attachments: LUCENE-4111.patch, LUCENE-4115.patch
>
>
> I think we should add the following target deps:
> ant clean [depends on] clean-jars
> ant resolve [depends on] clean-jars
> ant eclipse [depends on] resolve, clean-jars
> ant idea [depends on] resolve, clean-jars
> This eliminates the need to remember about cleaning up stale jars which users complain
about (and I think they're right about it). The overhead will be minimal since resolve is
only going to copy jars from cache. Eclipse won't have a problem with updated JARs if they
end up at the same location.
> If there are no objections I will fix this in a few hours.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message