lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steven Rowe (JIRA)" <>
Subject [jira] [Updated] (LUCENE-4172) clean up redundant throws clauses
Date Thu, 28 Jun 2012 08:40:44 GMT


Steven Rowe updated LUCENE-4172:

    Attachment: LUCENE-4172.patch

Patch with manually vetted IntelliJ finds for global "Redundant throws clauses", "Redundant
throws declarations", and "Duplicate throws".  Compiles; Lucene&Solr tests pass.

Robert, I added another bullet at the top of your list of allowable contexts in which to remove
redundant throws:

* nuke the redundant throws if the method is either in an anonymous inner class or in a final
* nuke the redundant throws if its a static method, private, or package-private, or final
* nuke the redundant throws if its a ctor (subclass can always declare its own)
* keep the redundant throws if its public/protected non-final method that can be overridden

> clean up redundant throws clauses
> ---------------------------------
>                 Key: LUCENE-4172
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Robert Muir
>         Attachments: LUCENE-4172.patch, LUCENE-4172.patch
> examples are things like ctors that list throws XYZException but actually dont, and things
like 'throws CorruptIndex, LockObtainedFailed, IOException' when all of these are actually

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message