lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4115) JAR resolution/ cleanup should be done automatically for ant clean/ eclipse/ resolve.
Date Fri, 08 Jun 2012 21:35:23 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292004#comment-13292004
] 

Hoss Man commented on LUCENE-4115:
----------------------------------

I'm not sure i'm following you.

right now, we know that when you run "ant test" (or "java -jar start.jar" in solr) you getting
the exact same classpath and set of jars as someone who downloads a binary dist you might
build from your checkout -- because the classpath you are using comes from the lib dirs, built
by ivy.  there is only one places jars are "copied" from the ivy cache to the lib dir(s).

if instead we have ant <classpath/> declarations that use ivy features to build up classpaths
pointed directly at jars in the ivy cache, and independently we have <copy> directives
building up the lib/ dirs that make it into the binary dists, then isn't there a risk that
(overtime) those will diverge in a way we might not notice because all the testing will only
be done with the ivy generated classpaths?

(maybe i'm wrong ... maybe the ivy classpath stuff works diff then i understand ... i'm just
raising it as a potential concern)
                
> JAR resolution/ cleanup should be done automatically for ant clean/ eclipse/ resolve.
> -------------------------------------------------------------------------------------
>
>                 Key: LUCENE-4115
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4115
>             Project: Lucene - Java
>          Issue Type: Task
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Trivial
>             Fix For: 4.0, 5.0
>
>         Attachments: LUCENE-4111.patch
>
>
> I think we should add the following target deps:
> ant clean [depends on] clean-jars
> ant resolve [depends on] clean-jars
> ant eclipse [depends on] resolve, clean-jars
> ant idea [depends on] resolve, clean-jars
> This eliminates the need to remember about cleaning up stale jars which users complain
about (and I think they're right about it). The overhead will be minimal since resolve is
only going to copy jars from cache. Eclipse won't have a problem with updated JARs if they
end up at the same location.
> If there are no objections I will fix this in a few hours.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message