lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4160) Bring back the functional equivalent of tests.iters.min
Date Mon, 25 Jun 2012 16:57:44 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400644#comment-13400644
] 

Hoss Man commented on LUCENE-4160:
----------------------------------

bq. "tests.iters.min=X" which is (still) kind of confusing to me because I don't understand
how "X" is related to the original question.

i think maybe you simplified the statement of the original question?

With tests.iters.min=X tests.iters=Y you were saying "attempt to run this test Y times, and
even if it fails, run it a minimum of X times." (at least, that was the theory as i understood
it, maybe it never actually worked that way).

bq. I propose to implement a boolean "tests.fastfail"

...the key here being that tests.iters today already repeats the test the specified number
of times, even if it fails -- and a new tests.fastfail" would default to "false" but if it
was true then you could have the old behavior of tests.iters.min=1.

seems fine to me ... i think hte main motivation of tests.iters.min isn't really applicable
anymore since the default logic for running multiple iterations is basically the reverse of
what it use to be. 

an alternative way to think about it would be to add a "tests.iters.max", since tests.iters
already behaves similar to what tests.iters.min use to do.

Or just say to hell with it, and people who want the X,Y equivilent from before can run...

{noformat}
ant -Dtestcase=... -Dtestmethod=... -Dtests.iters=X \
&& \
ant -Dtestcase=... -Dtestmethod=... -Dtests.failfast -Dtests.iters=${Y-X}
{noformat}

                
> Bring back the functional equivalent of tests.iters.min
> -------------------------------------------------------
>
>                 Key: LUCENE-4160
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4160
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: general/test
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Trivial
>             Fix For: 5.0
>
>
> What is needed is effectively saying: "repeat this test N times, but stop once you hit
a failure".
> Previously it was "tests.iters.min=X" which is (still) kind of confusing to me because
I don't understand how "X" is related to the original question.
> I propose to implement a boolean "tests.fastfail" which would ignore any tests running
on the same JVM after the first failure has been hit.
> Those with fond memories of "tests.iters.min" speak up, please.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message