lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] [Assigned] (LUCENE-4146) -Dtests.iters combined with -Dtestmethod never fails?
Date Tue, 19 Jun 2012 01:16:42 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-4146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Hoss Man reassigned LUCENE-4146:
--------------------------------

    Assignee: Hoss Man

bq. I realize this is confusing but this really doesn't stem from my code and is a non-fixable
JUnit API (because of how many things depend on it I doubt it'll ever be corrected).

I totally understand ... the missing piece for me was not realizing that the "filtering" happens
after the "paramaterizing" so a filter on "testFoo" won't match "testFoo[0]" etc...

bq. Other than that all your suggestions are fine by me. 

I'll fix test-help and make the change to our "testmethod" alias, but i'm not sure about this
one...

bq. change the code path that reads the system properties used to pick the tests to fail if
this combination (tests.iters + a non-globed "test method") is used (rather then silently
lying and saying (0) tests passed)

...unless i'm missing something, lucene's build xml files & test base class don't have
anything to do with parsing these system properties correct?  should i file this as a feature
request in the randomizedtesting tracker?
                
> -Dtests.iters combined with -Dtestmethod never fails?
> -----------------------------------------------------
>
>                 Key: LUCENE-4146
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4146
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Hoss Man
>            Assignee: Hoss Man
>         Attachments: LUCENE-4146.fail.patch, TEST-org.apache.lucene.TestSearch.iters-no-fail.xml,
TEST-org.apache.lucene.TestSearch.no-iters-fail.xml
>
>
> a test that is hardcoded to fail will report succes if you run it with -Dtests.iters

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message