lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Male (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4157) Improve Spatial Testing
Date Tue, 26 Jun 2012 15:42:44 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401461#comment-13401461
] 

Chris Male commented on LUCENE-4157:
------------------------------------

I think we should bump this to critical and really reconsider some this spatial code.  While
doing some work with it, I noticed that what testing there is primarily focused on using RecursivePrefixTreeStrategy
with geohashes.  I swapped in QuadPrefixTree and both tests in TestRecursivePrefixTreeStrategy
failed.  Worse yet when I used QuadPrefixTree with MAX_LEVELS_POSSIBLE, I get an error.  So
I don't think we can release QuadPrefixTree at this stage.

The code inside TestTermQueryPrefixGridStrategy seems to be some experimental code I wrote
over 12 months ago and doesn't actually test anything.  Porting it over to using the same
stuff as TestRecursivePrefixTreeStrategy shows that the Strategy does seem to work but again,
using QuadPrefixTree causes failures and errors.  

I'm also worried that really the only testing is using cities-IsWithin-BBox.txt which contains
only 3 queries.  There doesn't seem to be any automated testing of other operations or shapes
at this stage.

I wonder whether we should scale back what code is released in 4.0, focusing on what we have
good quality testing for and maybe put the remaining code into sandbox or just hold it back
in trunk till we have testing that shows it works.
                
> Improve Spatial Testing
> -----------------------
>
>                 Key: LUCENE-4157
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4157
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: modules/spatial
>            Reporter: David Smiley
>            Assignee: David Smiley
>             Fix For: 4.0
>
>         Attachments: LUCENE-4157_Improve_Lucene_Spatial_testing_p1.patch
>
>
> Looking back at the tests for the Lucene Spatial Module, they seem half-baked.  (At least
Spatial4j is well tested).  I've started working on some improvements:
> * Some tests are in an abstract base class which have a subclass that provides a SpatialContext.
The idea was that the same tests could test other contexts (such as geo vs not or different
distance calculators (haversine vs vincenty) but this can be done using RandomizedTesting's
nifty parameterized test feature, once there is a need to do this.
> * Port the complex geohash recursive prefix tree test that was developed on the Solr
side to the Lucene side where it belongs.
> And some things are not tested or aren't well tested:
> * Distance order as the query score
> * Indexing shapes other than points (i.e. shapes with area / regions)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message