lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (JIRA)" <>
Subject [jira] [Updated] (LUCENE-4157) Improve Spatial Testing
Date Thu, 28 Jun 2012 06:25:43 GMT


David Smiley updated LUCENE-4157:

    Attachment: LUCENE-4157_Improve_TermQueryPrefixTreeStrategy_and_move_makeQuery_impl_to_SpatialStrategy.patch

The attached patch improves TermQueryPrefixTreeStrategy:
* based on TermsFilter instead of BooleanQuery
* scores of Query are now via ValueSource and thus sorting is what we want now

These changes made some tests pass.  Those tests will be another patch (maybe tomorrow).

* refactored the generic makeQuery() impl from RecursivePrefixTreeFilter to become the default
impl in SpatialStrategy, used by both PrefixTree Strategies.

I'm going to commit this in a minute.
> Improve Spatial Testing
> -----------------------
>                 Key: LUCENE-4157
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: modules/spatial
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Critical
>             Fix For: 4.0
>         Attachments: LUCENE-4157_Improve_Lucene_Spatial_testing_p1.patch, LUCENE-4157_Improve_TermQueryPrefixTreeStrategy_and_move_makeQuery_impl_to_SpatialStrategy.patch
> Looking back at the tests for the Lucene Spatial Module, they seem half-baked.  (At least
Spatial4j is well tested).  I've started working on some improvements:
> * Some tests are in an abstract base class which have a subclass that provides a SpatialContext.
The idea was that the same tests could test other contexts (such as geo vs not or different
distance calculators (haversine vs vincenty) but this can be done using RandomizedTesting's
nifty parameterized test feature, once there is a need to do this.
> * Port the complex geohash recursive prefix tree test that was developed on the Solr
side to the Lucene side where it belongs.
> And some things are not tested or aren't well tested:
> * Distance order as the query score
> * Indexing shapes other than points (i.e. shapes with area / regions)

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message