lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4160) Bring back the functional equivalent of tests.iters.min
Date Thu, 28 Jun 2012 16:09:44 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403187#comment-13403187
] 

Hoss Man commented on LUCENE-4160:
----------------------------------

bq. I think i originally caused the complexity by wanting to still have a way to run a test
like 1000 times and look at the failure rate.

right, the original driving usecase is already possible with the way tests.iters works now;
it just so happened that the way it worked before you could not only say "run this test at
least 1000 times, even if it fails, so i can compute a pass/fail rate and look for patterns"
you could say "try to run this test at least 1000 times, even if it fails, so i can compute
a pass/fail rate and look for patterns -- but if it doesn't fail, just keep on trying up to
5000 times for good measure.  I'm going to lunch anyway."

if tests.maxfailures is just as easy to implement as tests.fastfail (and already implemented
in this patch) then i say go with that.

we can always add ant sugar so that -Dtests.failfast=true sets tests.maxfailures=1
                
> Bring back the functional equivalent of tests.iters.min
> -------------------------------------------------------
>
>                 Key: LUCENE-4160
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4160
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: general/test
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Trivial
>             Fix For: 5.0
>
>         Attachments: LUCENE-4160.patch
>
>
> What is needed is effectively saying: "repeat this test N times, but stop once you hit
a failure".
> Previously it was "tests.iters.min=X" which is (still) kind of confusing to me because
I don't understand how "X" is related to the original question.
> I propose to implement a boolean "tests.fastfail" which would ignore any tests running
on the same JVM after the first failure has been hit.
> Those with fond memories of "tests.iters.min" speak up, please.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message