lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dawid Weiss (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3832) Port BasicAutomata.stringUnion from Brics to Lucene
Date Thu, 28 Jun 2012 10:09:44 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402979#comment-13402979
] 

Dawid Weiss commented on LUCENE-3832:
-------------------------------------

My whining doesn't mean I want to change this because I realize most of the data in Lucene
already comes as UTF8 and it wouldn't make sense to convert it back and forth. This doesn't
change my feeling that it isn't intuitive when you look at the method's signature.

Of course it's explained in the javadoc what it actually does, but so is conversion/ sorting
in that other method that you don't like (and that I think is generally useful considering
the rest of this package).
                
> Port BasicAutomata.stringUnion from Brics to Lucene
> ---------------------------------------------------
>
>                 Key: LUCENE-3832
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3832
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: core/FSTs
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Trivial
>             Fix For: 4.0, 5.0
>
>         Attachments: LUCENE-3832.patch, LUCENE-3832.patch
>
>
> Brics has my code to build Automaton from a set of sorted strings in one step (Daciuk/Mihov's
algorithm again). This should be easily portable to Lucene and is quite useful.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message