lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4128) add safety to preflex segmentinfo "upgrade"
Date Mon, 11 Jun 2012 12:17:42 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292770#comment-13292770
] 

Michael McCandless commented on LUCENE-4128:
--------------------------------------------

Good idea, I'll do that!
                
> add safety to preflex segmentinfo "upgrade"
> -------------------------------------------
>
>                 Key: LUCENE-4128
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4128
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>            Assignee: Michael McCandless
>             Fix For: 4.0
>
>         Attachments: LUCENE-4128.patch
>
>
> Currently the one-time-upgrade depends on whether the upgraded .si file exists. And the
writing is done in a try/finally so its removed if ioexception happens.
> but I think there could be a power-loss or something else in the middle of this, the
upgraded .si file could be bogus, then the user would have to manually remove it (they probably
wouldnt know).
> i think instead we should just have a marker file on completion, that we create after
we successfully fsync the upgraded .si file. this way if something happens we just rewrite
the thing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message