lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dawid Weiss (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4146) -Dtests.iters combined with -Dtestmethod never fails?
Date Tue, 19 Jun 2012 07:53:43 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13396587#comment-13396587
] 

Dawid Weiss commented on LUCENE-4146:
-------------------------------------

bq. ...not realizing that the "filtering" happens after the "paramaterizing" so a filter on
"testFoo" won't match "testFoo[0]" etc...

This is hairy in JUnit. I mean design wise it's very pretty because filtering is completely
separated from the structure of tests but in practice the test runner knows nothing about
the filter. It would all work if test Description class had a separate notion of "test class,
test method and test name". Instead, these things are derivatives of each other in an ugly-to-fix
way. Even creating a test with a custom name is challenging...

http://grepcode.com/file_/repo1.maven.org/maven2/junit/junit/4.10/org/junit/runner/Description.java/?v=source

> ...unless i'm missing something, lucene's build xml files & test base class don't
have anything to do with parsing these system properties correct? should i file this as a
feature request in the randomizedtesting tracker?

This combination is valid in some cases -- for example if you want to filter down to a particular
repetition of a repeated test (which has a particular seed) you still can do it, so I wouldn't
want to ban it at the runner level. What I was thinking about was to use ANT's condition and
check a compound statement that would fail if both properties are non-empty and method filter
doesn't contain "*". ANT's conditions are screwy but I'm sure it can be done.



                
> -Dtests.iters combined with -Dtestmethod never fails?
> -----------------------------------------------------
>
>                 Key: LUCENE-4146
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4146
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Hoss Man
>            Assignee: Hoss Man
>         Attachments: LUCENE-4146.fail.patch, TEST-org.apache.lucene.TestSearch.iters-no-fail.xml,
TEST-org.apache.lucene.TestSearch.no-iters-fail.xml
>
>
> a test that is hardcoded to fail will report succes if you run it with -Dtests.iters

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message