lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steven Rowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4172) clean up redundant throws clauses
Date Fri, 29 Jun 2012 06:51:44 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403733#comment-13403733
] 

Steven Rowe commented on LUCENE-4172:
-------------------------------------

bq. What's wrong with?:  import <package>.*; – especially when there are many classes?

Some reasons given here: [http://stackoverflow.com/questions/147454/why-is-using-a-wild-card-with-a-java-import-statement-bad]:
namespace polution; package additions can trigger compilation failure; compilation is slower.

My IDE (IntelliJ) automatically folds imports, so assuming most devs have a similar experience,
many classes in a package don't cause actual clutter.

bq. And is there a coding standard that Lucene/Solr adheres to? I am unaware.

The only standard I've seen referred to is "Sun's Java style rules, with the exception of
2 spaces per indent level instead of 4".
                
> clean up redundant throws clauses
> ---------------------------------
>
>                 Key: LUCENE-4172
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4172
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Robert Muir
>            Assignee: Steven Rowe
>             Fix For: 4.0, 5.0
>
>         Attachments: LUCENE-4172.patch, LUCENE-4172.patch, LUCENE-4172.patch
>
>
> examples are things like ctors that list throws XYZException but actually dont, and things
like 'throws CorruptIndex, LockObtainedFailed, IOException' when all of these are actually
IOException.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message