Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 59683C3C6 for ; Wed, 16 May 2012 08:02:32 +0000 (UTC) Received: (qmail 2335 invoked by uid 500); 16 May 2012 08:02:31 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 2169 invoked by uid 500); 16 May 2012 08:02:30 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 2151 invoked by uid 99); 16 May 2012 08:02:30 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 May 2012 08:02:30 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 May 2012 08:02:28 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 2B997641D for ; Wed, 16 May 2012 08:02:07 +0000 (UTC) Date: Wed, 16 May 2012 08:02:07 +0000 (UTC) From: "Robert Muir (JIRA)" To: dev@lucene.apache.org Message-ID: <442306707.3233.1337155327180.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <647127321.57804.1336812348947.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (LUCENE-4051) Fix File Headers for Lucene40 StoredFields & TermVectors MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LUCENE-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276566#comment-13276566 ] Robert Muir commented on LUCENE-4051: ------------------------------------- Patch looks good! Can you update the fileformat javadocs (in Lucene40*Format.java) to document the codec header? In the other places we just treat it like a primitive type and link it to CodecUtil#writeHeader where its format is described in detail. > Fix File Headers for Lucene40 StoredFields & TermVectors > -------------------------------------------------------- > > Key: LUCENE-4051 > URL: https://issues.apache.org/jira/browse/LUCENE-4051 > Project: Lucene - Java > Issue Type: Task > Components: core/codecs > Affects Versions: 4.0 > Reporter: Simon Willnauer > Assignee: Simon Willnauer > Fix For: 4.0 > > Attachments: LUCENE-4051.patch, LUCENE-4051.patch, LUCENE-4051.patch > > > Currently we still write the "old" file header format in Lucene40StoredFieldFormat & Lucene40TermVectorsFormat. We should cut over to use CodecUtil and reset the versioning before we release Lucene 4.0 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org