Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Date: Fri, 18 May 2012 07:55:12 +0000 (UTC)
From: "Dawid Weiss (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: 
 <142995311.13143.1337327715075.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <101050807.59491.1336897010163.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (LUCENE-4054) Overrides of @Before or @After
 hooks should cause a test error.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/LUCENE-4054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278637#comment-13278637 ] 

Dawid Weiss commented on LUCENE-4054:
-------------------------------------

Committed a fix for this.
                
> Overrides of @Before or @After hooks should cause a test error.
> ---------------------------------------------------------------
>
>                 Key: LUCENE-4054
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4054
>             Project: Lucene - Java
>          Issue Type: Sub-task
>          Components: general/build, general/test
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Trivial
>             Fix For: 4.0
>
>
> The only exceptions are setUp/ tearDown methods in LuceneTestCase, which are historically designed for overriding (and for which chaining is verified). Any other override of am instance hook method should just be banned as it is very likely a mistake.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org