lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steven Rowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4054) Overrides of @Before or @After hooks should cause a test error.
Date Fri, 18 May 2012 15:31:06 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278865#comment-13278865
] 

Steven Rowe commented on LUCENE-4054:
-------------------------------------

Thanks Dawid - IntelliJ now shows an icon indicating the affected test is ignored, and no
exception is printed.
                
> Overrides of @Before or @After hooks should cause a test error.
> ---------------------------------------------------------------
>
>                 Key: LUCENE-4054
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4054
>             Project: Lucene - Java
>          Issue Type: Sub-task
>          Components: general/build, general/test
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Trivial
>             Fix For: 4.0
>
>
> The only exceptions are setUp/ tearDown methods in LuceneTestCase, which are historically
designed for overriding (and for which chaining is verified). Any other override of am instance
hook method should just be banned as it is very likely a mistake.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message