lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christoph Kaser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4077) ToParentBlockJoinCollector provides no way to access computed scores and the maxScore
Date Tue, 29 May 2012 08:29:24 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284660#comment-13284660
] 

Christoph Kaser commented on LUCENE-4077:
-----------------------------------------

Hello Mike,

thank you for the patch. There is one small problem: ToParentBlockJoinCollector.getMaxScore()
always returns _NaN_. This happens because maxScore is initialized as 
{code}
private float maxScore = Float.NaN;
{code}
and then updated as
{code}
maxScore = Math.max(score, maxScore);
{code}
which is always _NaN_.

I hope I applied the patch to the correct revision and this is not caused by a version conflict.
                
> ToParentBlockJoinCollector provides no way to access computed scores and the maxScore
> -------------------------------------------------------------------------------------
>
>                 Key: LUCENE-4077
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4077
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: modules/join
>    Affects Versions: 3.4, 3.5, 3.6
>            Reporter: Christoph Kaser
>            Assignee: Michael McCandless
>         Attachments: LUCENE-4077.patch
>
>
> The constructor of ToParentBlockJoinCollector allows to turn on the tracking of parent
scores and the maximum parent score, however there is no way to access those scores because:
> * maxScore is a private field, and there is no getter
> * TopGroups / GroupDocs does not provide access to the scores for the parent documents,
only the children

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message