lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4043) Add scoring support for query time join
Date Mon, 28 May 2012 14:39:24 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284417#comment-13284417
] 

Michael McCandless commented on LUCENE-4043:
--------------------------------------------

Patch looks great!

You don't need to use your own growFactor ... just call ArrayUtil.grow
directly (it already oversizes under the hood for you).

Maybe remove @throws IAE from createJoinQuery's javadocs?  (But, still
throw it... in case we add a new ScoreMode and forget to fix this
code, in the future).  Because today all ScoreMode enum values work...

Fix omitted to emitted in the comment on top of "class MVInnerScorer".

Probably javadocs should somewhere explain about the "first time doc
is emitted it gets that score"?

Maybe explain added RAM requirements when scores are tracked in the
javadocs?

Maybe rename TermsWithScoreCollector.MV.Avg.ordScores -> .scoreCounts
(and .scores -> .scoreSums?).

Can we put back the non-wildcard imports?

                
> Add scoring support for query time join
> ---------------------------------------
>
>                 Key: LUCENE-4043
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4043
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: modules/join
>            Reporter: Martijn van Groningen
>         Attachments: LUCENE-4043.patch, LUCENE-4043.patch, LUCENE-4043.patch
>
>
> Have similar scoring for query time joining just like the index time block join (with
the score mode).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message