lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tommaso Teofili (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-3350) TextField's parseFieldQuery method not using analyzer's enablePosIncr parameter
Date Thu, 31 May 2012 12:43:23 GMT

    [ https://issues.apache.org/jira/browse/SOLR-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286531#comment-13286531
] 

Tommaso Teofili commented on SOLR-3350:
---------------------------------------

for now I think we can at least remove the useless switches inside the code, as the broader
discussion about "overall" enablePositionIncrements isn't trivial.
                
> TextField's parseFieldQuery method not using analyzer's enablePosIncr parameter
> -------------------------------------------------------------------------------
>
>                 Key: SOLR-3350
>                 URL: https://issues.apache.org/jira/browse/SOLR-3350
>             Project: Solr
>          Issue Type: Bug
>          Components: Schema and Analysis
>    Affects Versions: 3.5, 4.0
>            Reporter: Tommaso Teofili
>            Priority: Minor
>
> parseFieldQuery method of TextField class just set 
> {code}
>   ...
>   boolean enablePositionIncrements = true;
>   ...
> {code}
> while that should be taken from Analyzer's configuration.
> The above condition is evaluated afterwards in two points:
> {code}
>   ...
>   if (enablePositionIncrements) {
>     mpq.add((Term[]) multiTerms.toArray(new Term[0]), position);
>   } else {
>     mpq.add((Term[]) multiTerms.toArray(new Term[0]));
>   }
>   return mpq;
>   ...
>   ...
>   if (enablePositionIncrements) {
>     position += positionIncrement;
>     pq.add(new Term(field, term), position);
>   } else {
>      pq.add(new Term(field, term));
>   }
>   ...
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message