lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4047) Cleanup of LuceneTestCase
Date Mon, 14 May 2012 22:22:31 GMT



























<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2)
{
    #email-body { min-width: 30em !important; }
    #email-page { padding: 8px !important; }
    #email-banner { padding: 8px 8px 0 8px !important; }
    #email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
    #email-fields { padding: 0 8px 8px 8px !important; }
    #email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;">
    <tr valign="top">
        <td id="email-page" style="padding:16px !important;">
            <table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px
solid #bbbbbb;color:#000000;width:100%;">
                <tr valign="top">
                    <td bgcolor="#ffffff" style="background-color:#ffffff;color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img
src="https://issues.apache.org/jira/s/en_UKy3do2c/731/4/_/images/asf_logo_wide.gif" alt=""
style="vertical-align:top;" /></td>
                </tr><tr valign="top">
    <td id="email-banner" style="padding:32px 32px 0 32px;">

                
        
        
            <table align="left" border="0" cellpadding="0" cellspacing="0" width="100%"
style="width:100%;">
    <tr valign="top">
        <td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
                                        <img id="email-avatar" src="https://issues.apache.org/jira/secure/useravatar?ownerId=rcmuir&avatarId=10150"
alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px
0;" />
                        <div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;">
                                    <a class="user-hover" rel="rcmuir" id="email_rcmuir"
href="https://issues.apache.org/jira/secure/ViewProfile.jspa?name=rcmuir" style="color:#326ca6;">Robert
Muir</a>
     commented on <img src="https://issues.apache.org/jira/images/icons/issue_subtask.gif"
height="16" width="16" border="0" align="absmiddle" alt="Sub-task"> <a style='color:#326ca6;text-decoration:none;'
href='https://issues.apache.org/jira/browse/LUCENE-4047'>LUCENE-4047</a>
            </div>
                        <div id="email-summary" style="font-size:16px;line-height:20px;padding:2px
0 16px 0;">
                <a style='color:#326ca6;text-decoration:none;' href='https://issues.apache.org/jira/browse/LUCENE-4047'><strong>Cleanup
of LuceneTestCase</strong></a>
            </div>
                    </td>
    </tr>
</table>
    </td>
</tr>
<tr valign="top">
    <td id="email-fields" style="padding:0 32px 32px 32px;">
        <table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;"
width="100%">
            <tr valign="top">
                <td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
                <td>
                    <table border="0" cellpadding="0" cellspacing="0" width="100%">
                        <tr valign="top">
    <td colspan="2" style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0
0 16px 0;width:100%;">
        <div class="comment-block" style="background-color:#edf5ff;border:1px solid #dddddd;color:#000000;padding:12px;"><p>Summary
of concerns:</p>
<ul>
	<li>if we close the mdw and ignore exceptions, its not any better than today as in
general the MDW will still have files open against it and will simply throw an exception and
not actually close anything.</li>
	<li>if we don't fix MDW etc to actually close (even when ugly stuff happens), then
failed tests will cause leaks (imagine RAM directories piling up in the JVM)</li>
</ul>


<p>So my opinion is, since the rest of this patch is a nice cleanup, we should commit
it without the MDW.close() change... for now. We should separately open a issue to fix MDW
and anything like it to always actually close() its delegate in a finally block, ensuring
it doesn't lose any real exceptions from any of its openfiles/checkindex/crash/unrefed fields
checks.</p>
</div>
        <div style="color:#505050;padding:4px 0 0 0;">                </div>
    </td>
</tr>
                    </table>
                </td>
            </tr>
        </table>
    </td>
</tr>













            </table>
        </td><!-- End #email-page -->
    </tr>
    <tr valign="top">
        <td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding:
0 16px 16px 16px;text-align:center;">
            This message is automatically generated by JIRA.<br />
            If you think it was sent incorrectly, please contact your <a style='color:#326ca6;'
href='https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa'>JIRA administrators</a>.<br
/>
            For more information on JIRA, see: <a style='color:#326ca6;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
        </td>
    </tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message