lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (LUCENE-3489) Refactor test classes that use assumeFalse(codec != SimpleText, Memory) to use new annotation and move the expensive methods to separate classes
Date Fri, 11 May 2012 21:41:50 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-3489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Robert Muir updated LUCENE-3489:
--------------------------------

    Attachment: LUCENE-3489.patch

attached is a patch generalizing the UseNoExpensiveMemory annotation to @AvoidCodecs that
takes a list of codecs to avoid.

This way, tests that cannot work with Lucene3x codec can just avoid it, using another codec,
rather than assuming (in general its bad that many of the tests of actual new functionality
often dont run at all because of the current assumes) 
                
> Refactor test classes that use assumeFalse(codec != SimpleText, Memory) to use new annotation
and move the expensive methods to separate classes
> ------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3489
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3489
>             Project: Lucene - Java
>          Issue Type: Test
>          Components: general/test
>    Affects Versions: 4.0
>            Reporter: Uwe Schindler
>             Fix For: 4.1
>
>         Attachments: LUCENE-3489.patch
>
>
> Folloup for LUCENE-3463.
> TODO:
> - Move test-methods that need the new @UseNoMemoryExpensiveCodec annotation to separate
classes
> - Eliminate the assumeFalse-calls that check the current codec and disable the test if
SimpleText or Memory is used

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message