lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4047) Cleanup of LuceneTestCase
Date Mon, 14 May 2012 14:39:51 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13274618#comment-13274618
] 

Robert Muir commented on LUCENE-4047:
-------------------------------------

At a glance, the rest of the patch looks great! I think just whenever we close an MDW, we
should not be hiding  any exceptions it throws, worst case we should wrap in runtime exception.

                
> Cleanup of LuceneTestCase
> -------------------------
>
>                 Key: LUCENE-4047
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4047
>             Project: Lucene - Java
>          Issue Type: Sub-task
>          Components: general/build, general/test
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: LUCENE-4047.patch
>
>
> functionally split large blocks of code that do logically different things, organize
and order them into rules. Use RandomizedRunner facilities for ensuring scope resources (Directory,
temporary folders) are properly disposed of. Use RandomizedRunner facilities for reporting
reproduce message.
> I have a working branch for this at github. Polishing off the rough edges.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message