lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martijn van Groningen (JIRA)" <>
Subject [jira] [Updated] (LUCENE-4043) Add scoring support for query time join
Date Mon, 28 May 2012 19:10:23 GMT


Martijn van Groningen updated LUCENE-4043:

    Attachment: LUCENE-4043.patch

Thanks for reviewing Mike! I've updated the patch.

bq. You don't need to use your own growFactor ... just call ArrayUtil.grow directly (it already
oversizes under the hood for you).
Sure. (I didn't release that the ArrayUtil#oversize() was doing this)

bq. Maybe remove @throws IAE from createJoinQuery's javadocs? (But, still throw it... in case
we add a new ScoreMode and forget to fix this code, in the future). Because today all ScoreMode
enum values work...
Makes sense. We design it not to throw the exception. If the exception is thrown, then it
is a bug.

bq. Fix omitted to emitted in the comment on top of "class MVInnerScorer".

bq. Probably javadocs should somewhere explain about the "first time doc is emitted it gets
that score"?
bq. Maybe explain added RAM requirements when scores are tracked in the javadocs?

bq. Maybe rename TermsWithScoreCollector.MV.Avg.ordScores -> .scoreCounts (and .scores
-> .scoreSums?).

bq. Can we put back the non-wildcard imports?
Done. (IDE was trying to be smart... I'll change my settings...)
> Add scoring support for query time join
> ---------------------------------------
>                 Key: LUCENE-4043
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: modules/join
>            Reporter: Martijn van Groningen
>         Attachments: LUCENE-4043.patch, LUCENE-4043.patch, LUCENE-4043.patch, LUCENE-4043.patch
> Have similar scoring for query time joining just like the index time block join (with
the score mode).

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message