lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dawid Weiss (JIRA)" <>
Subject [jira] [Commented] (LUCENE-4083) RateLimited.pause() throws unchecked exception
Date Tue, 29 May 2012 17:53:24 GMT


Dawid Weiss commented on LUCENE-4083:

bq. Thread.sleep() with potentially large values, which occasionally results in InterruptedException
being thrown from Thread.sleep()

There are no "spurious interrupts" from sleep... something has interrupted that thread so
just not re-throwing is probably not a good idea?
> RateLimited.pause() throws unchecked exception
> ----------------------------------------------
>                 Key: LUCENE-4083
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: core/store
>    Affects Versions: 4.0
>            Reporter: Andrzej Bialecki 
>             Fix For: 4.0
> The while() loop in RateLimiter.pause() invokes Thread.sleep() with potentially large
values, which occasionally results in InterruptedException being thrown from Thread.sleep().
This is wrapped in an unchecked ThreadInterruptedException and re-thrown, and results in high-level
errors like this:
> {code}
>     [junit] 2012-05-29 15:50:15,464 ERROR core.SolrCore - org.apache.lucene.util.ThreadInterruptedException:
java.lang.InterruptedException: sleep interrupted
>     [junit] 	at
>     [junit] 	at
>     [junit] 	at
>     [junit] 	at
>     [junit] 	at org.apache.lucene.codecs.lucene40.Lucene40PostingsWriter.addPosition(
>     [junit] 	at org.apache.lucene.index.FreqProxTermsWriterPerField.flush(
>     [junit] 	at org.apache.lucene.index.FreqProxTermsWriter.flush(
>     [junit] 	at org.apache.lucene.index.TermsHash.flush(
>     [junit] 	at org.apache.lucene.index.DocInverter.flush(
>     [junit] 	at org.apache.lucene.index.DocFieldProcessor.flush(
>     [junit] 	at org.apache.lucene.index.DocumentsWriterPerThread.flush(
>     [junit] 	at org.apache.lucene.index.DocumentsWriter.doFlush(
>     [junit] 	at org.apache.lucene.index.DocumentsWriter.flushAllThreads(
>     [junit] 	at org.apache.lucene.index.IndexWriter.prepareCommit(
>     [junit] 	at org.apache.lucene.index.IndexWriter.commitInternal(
>     [junit] 	at org.apache.lucene.index.IndexWriter.commit(
>     [junit] 	at org.apache.solr.update.DirectUpdateHandler2.commit(
>     [junit] 	at org.apache.solr.update.processor.RunUpdateProcessor.processCommit(
> {code}
> I believe this is a bug - the while() loop already ensures that the total time spent
in pause() is correct even if InterruptedException-s are thrown, so they should not be re-thrown.
> The patch is trivial - simply don't re-throw.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message