lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christoph Kaser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4077) ToParentBlockJoinCollector provides no way to access computed scores and the maxScore
Date Wed, 30 May 2012 14:37:22 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285702#comment-13285702
] 

Christoph Kaser commented on LUCENE-4077:
-----------------------------------------

Hi Mike,

shouldn't TopGroups.maxScore contain the maximum parent score? If I am not mistaken, the way
it is built now, it contains the maximum child score over all children.

This is due to this line in ToParentBlockJoinCollector.getTopGroups():
{code}
maxScore = Math.max(maxScore, topDocs.getMaxScore());
{code}

I think it should read:
{code}
totalMaxScore = Math.max(totalMaxScore, og.score);
{code}

Otherwise, topGroups.maxScore is different to ToParentBlockJoinCollector.getMaxScore()
                
> ToParentBlockJoinCollector provides no way to access computed scores and the maxScore
> -------------------------------------------------------------------------------------
>
>                 Key: LUCENE-4077
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4077
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: modules/join
>    Affects Versions: 3.4, 3.5, 3.6
>            Reporter: Christoph Kaser
>            Assignee: Michael McCandless
>         Attachments: LUCENE-4077.patch, LUCENE-4077.patch, LUCENE-4077.patch
>
>
> The constructor of ToParentBlockJoinCollector allows to turn on the tracking of parent
scores and the maximum parent score, however there is no way to access those scores because:
> * maxScore is a private field, and there is no getter
> * TopGroups / GroupDocs does not provide access to the scores for the parent documents,
only the children

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message