lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (" <>
Subject Re: Contribute 4.0 NRT source
Date Wed, 30 May 2012 14:22:38 GMT

Simply open a JIRA issue and attach a patch.  Lucene/Solr development
largely centers around JIRA issues via the comments.

Ideally you should provide tests as part of your patch; it certainly won't
be committed if sufficient tests are never furnished.  If your NRT
implementation really works, then I suppose you could modify existing tests
to do an NRT commit, then those tests should work.  I am not suggesting
modifying every test, instead I am suggesting modifying a solrconfig.xml
used in many tests or modify some test infrastructure code to trigger a
commit via your method vs. the standard path.  Even if this isn't committed
as such (e.g. committing all tests to do NRT), seeing existing tests pass
will give confidence in your approach.

NRT isn't my area of expertise, but I strongly suspect there are critical
false assumptions with your approach if Yonik et. all didn't use this
approach.  For example, you speak of not needing to invalidate caches
associated with SolrIndexSearcher on an NRT commit.  But shouldn't most of
those caches be invalid if you are committing new data you want searchable? 
An example is the UnInvertedField cache for faceting on multi-valued fields. 
Anyway; this is a conversation better done in JIRA because it is more
traceable to your contribution.

~ David

View this message in context:
Sent from the Lucene - Java Developer mailing list archive at

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message