lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-3346) qt Dispatching Request Handler
Date Fri, 18 May 2012 00:01:29 GMT

    [ https://issues.apache.org/jira/browse/SOLR-3346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278434#comment-13278434
] 

Hoss Man commented on SOLR-3346:
--------------------------------

bq. Credit: Hoss's idea

to be clear, i did not suggest that we should eliminate qt support from SolrDispatchFilter.

what i said in SOLR-3161 was...

{quote}
change the example solrocnfig to use handleSelect="false"
 ...
Bonus points: someone can write a DispatchingRequestHandler that can optionally be configured
with some name (such as "/select") and does nothing put look for a "qt" param and forward
to the handler with that name – but it can have configuration options indicating which names
are permitted (and any other names would be rejected)
{quote}

my entire point was that we should leave in support for 'handleSelect="true"' exactly as it
is for the multitudes of existing users who are happy using "qt" w/o any security concerns,
but that we could _also_ offer an optional DispatchingRequestHandler for people who want param
based dispatching but want to limit it to only certain handlers

                
> qt Dispatching Request Handler
> ------------------------------
>
>                 Key: SOLR-3346
>                 URL: https://issues.apache.org/jira/browse/SOLR-3346
>             Project: Solr
>          Issue Type: New Feature
>          Components: search
>            Reporter: David Smiley
>             Fix For: 4.1
>
>
> Instead of 'qt' being handled by the SolrDispatchFilter (a Servlet Filter), it would
be better implemented as a request handler, with a suggested name of DispatchingRequestHandler.
 This is better because:
> * it keeps the servlet filter more focused / simplified (albeit just a little)
> * it simplifies solrconfig.xml by removing/deprecating handleSelect="true".  'qt' is
less magic, it works more explicitly.
> * if you don't want to use 'qt' dispatch, simply don't use DispatchingRequestHandler
> * DispatchingRequestHandler would get used by EmbeddedSolrServer but SolrDispatchFilter
is not.
> Credit: Hoss's idea, Erik coded a first draft

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message