lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4047) Cleanup of LuceneTestCase
Date Mon, 14 May 2012 18:01:58 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13274806#comment-13274806
] 

Robert Muir commented on LUCENE-4047:
-------------------------------------

{quote}
I assume the "unclosed directory" exception indicates more serious flaw in the test and this
should be fixed first?
{quote}

I don't think thats the case here. I guess its unclear to me if this close-hide-throwable
is only used
when the test is already going to fail anyway, and I see your point that today no closing
happens, but
from my POV i just think we should not mask any exceptions coming from MDW.close().

If MDW.close() throws an exception because checkindex failed, this is really serious, and
I don't
care what happened elsewhere in the test.


                
> Cleanup of LuceneTestCase
> -------------------------
>
>                 Key: LUCENE-4047
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4047
>             Project: Lucene - Java
>          Issue Type: Sub-task
>          Components: general/build, general/test
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: LUCENE-4047.patch
>
>
> functionally split large blocks of code that do logically different things, organize
and order them into rules. Use RandomizedRunner facilities for ensuring scope resources (Directory,
temporary folders) are properly disposed of. Use RandomizedRunner facilities for reporting
reproduce message.
> I have a working branch for this at github. Polishing off the rough edges.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message