Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EE3BF999F for ; Tue, 17 Apr 2012 20:39:42 +0000 (UTC) Received: (qmail 9049 invoked by uid 500); 17 Apr 2012 20:39:41 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 8991 invoked by uid 500); 17 Apr 2012 20:39:41 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 8983 invoked by uid 99); 17 Apr 2012 20:39:41 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Apr 2012 20:39:41 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of rcmuir@gmail.com designates 209.85.210.176 as permitted sender) Received: from [209.85.210.176] (HELO mail-iy0-f176.google.com) (209.85.210.176) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Apr 2012 20:39:35 +0000 Received: by iagw33 with SMTP id w33so12717902iag.35 for ; Tue, 17 Apr 2012 13:39:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; bh=IjlJJgNdn4+8R1Quz3A3Dq+P5QsFW3JRvCfGHTM8nlQ=; b=CwTu6CkO6KF3j5yAGIjOLQkrKsEVpTPbVxShlPQEcvidhLBoJ5eMQVaF1T5hG7v0NR 01joB3z709fGgHceX1n708lmJl+FtBTbzCrIxtc5ujDek+dKgG+RcEMgq1HPCxXv1AAM 4l7wSTaG2ipdoKWjMzDxZmcWP/4Q+qELaYAfhxv9Fs/P/1kxDK+ijWeCLhVo50Sjs/2T F7d4vC8gD+nMiImX0VzSBcAxfIt3wyM8bQnka57ksUx9lLXJu74JqUZrV5txPC8eRZq+ PBvCs4t1kEb5Exmfa78ZNB7aB5Y4Wdy8nU7GpneGSr3L4OVXmqggUncQ7B97h5oo3mD1 7Jgg== Received: by 10.42.117.129 with SMTP id t1mr11280325icq.0.1334695155098; Tue, 17 Apr 2012 13:39:15 -0700 (PDT) MIME-Version: 1.0 Received: by 10.50.216.170 with HTTP; Tue, 17 Apr 2012 13:38:54 -0700 (PDT) In-Reply-To: References: <155549543.33175.1334675659390.JavaMail.tomcat@hel.zones.apache.org> <462737576.34090.1334687360124.JavaMail.tomcat@hel.zones.apache.org> From: Robert Muir Date: Tue, 17 Apr 2012 16:38:54 -0400 Message-ID: Subject: Re: (LUCENE-3994) some nightly tests take hours To: dev@lucene.apache.org Content-Type: text/plain; charset=UTF-8 X-Virus-Checked: Checked by ClamAV on apache.org Digging in a bit into the slow nightlies, I think this explains a lot (see my other email: question about seed) I opened https://issues.apache.org/jira/browse/LUCENE-3995, but honestly i would really prefer if we didnt have to change our tests here, if somehow, when we do getRandom() the class's hashcode or something like that is xored with the seed to mix it up a bit, I think it would be ok. I can easily fix LuceneTestCase/SolrTestCaseJ4/etc but there are many tests that do stuff in beforeClass (e.g. build a directory), so if all tests are 'doing the same thing' we get less predictable test times, and less test efficiency. This is because there is redundancy in our tests (of course), which I think is ok, actually good, as long as these defaults are varying per-test-class such that we get wide coverage within a single 'ant test'. On Tue, Apr 17, 2012 at 3:53 PM, Robert Muir wrote: > I haven't looked, but i seriously doubt thats responsible at all. > Thats just an example "crazy" one. > > More likely it got SimpleText codec :) > > On Tue, Apr 17, 2012 at 3:49 PM, Dawid Weiss > wrote: >>> Like this? :) >>> >>> https://builds.apache.org/job/Lucene-trunk/1896/testReport/org.apache.lucene.index/TestIndexWriterReader/history/ >> >> If it's correlated with the commit of RandomizedRunner then I'd check >> if it's not that "asserting" Random instance or random() being >> repeatedly called gazillion times. Like I said -- there is an extra >> cost for these assertions so in tight loops (where there is no >> possibility of Random escaping to another thread, etc.), I'd just >> create a simple Random rnd = new Random(random().nextLong()). >> >> Dawid >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org >> For additional commands, e-mail: dev-help@lucene.apache.org >> > > > > -- > lucidimagination.com -- lucidimagination.com --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org