Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id ED49F969A for ; Thu, 5 Apr 2012 21:58:36 +0000 (UTC) Received: (qmail 99935 invoked by uid 500); 5 Apr 2012 21:58:35 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 99884 invoked by uid 500); 5 Apr 2012 21:58:35 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 99876 invoked by uid 99); 5 Apr 2012 21:58:35 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Apr 2012 21:58:35 +0000 X-ASF-Spam-Status: No, hits=1.7 required=5.0 tests=FREEMAIL_ENVFROM_END_DIGIT,HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of achmetow84@googlemail.com designates 209.85.215.48 as permitted sender) Received: from [209.85.215.48] (HELO mail-lpp01m010-f48.google.com) (209.85.215.48) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Apr 2012 21:58:30 +0000 Received: by lagu2 with SMTP id u2so2605209lag.35 for ; Thu, 05 Apr 2012 14:58:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=ci8TpR3iodDjrv+uLfGRolgSlfrDiS4EGWDd6Kf1/us=; b=MWIS2y9JCva7+QExI0LSIdU/Z6kOalMzNVr8o/6BQEjzJLgUTIiZZiyGAqNAcxQ11T VT7y9lESGcM/FajrHgAsdAXqu2NYXkJZhwjJoJUuTQlPWWIDiz2psgbAkKyBUWWNo6Fp rWQAWtauwydthMMBjzXovCXaHSu92vEREh/aXqDYcfFUxGMlGcUZifZgK5/zcQa+RntN S7cpdA8i0VCYFnzynLiZORrfx2rmLZpS6FV/tfDhCgYZ88FQxzNLWxB/VNvUVetGXOx4 BMiFSuwlvKKj7yCtWcY+z0VBnoAtPv6Qbyi0LrrfchvNvGI6icDvMdYA7j9FfcxWGNv6 hVtg== MIME-Version: 1.0 Received: by 10.152.129.74 with SMTP id nu10mr5328215lab.50.1333663089054; Thu, 05 Apr 2012 14:58:09 -0700 (PDT) Received: by 10.112.88.5 with HTTP; Thu, 5 Apr 2012 14:58:09 -0700 (PDT) Date: Thu, 5 Apr 2012 23:58:09 +0200 Message-ID: Subject: Re: GSoC 2012 - Refactoring IndexWriter (LUCENE-2026) From: Timur Achmetow To: dev@lucene.apache.org Content-Type: multipart/alternative; boundary=f46d042c6b97ac52b104bcf5a2e3 X-Virus-Checked: Checked by ClamAV on apache.org --f46d042c6b97ac52b104bcf5a2e3 Content-Type: text/plain; charset=ISO-8859-1 Hi, here's my first suggestion for the Refactoring steps: By now is the IW-class very big and i would try to reduce the code, by delegate special functions to the new components (Pattern: SRP). So keeps the IndexWriter most of his APIs and delegates "only". I would try to extract the internals from the following methods into new components; for example, it could look like this; - addDocument: component SegementWriter - addIndexes: component IndexbasedWriter What you think? Other ideas / suggestions / tips? Should I have to send the mail to the lucene mailing list? Thx for the feedback Tim --f46d042c6b97ac52b104bcf5a2e3 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Hi,
=A0
here's my first=20 suggestion for the Refactoring steps:
=A0
By now is the IW-class very big and i would try to reduce the code,
by delegate special functions to the new components (Pattern: SRP).
So keeps the IndexWriter most of his APIs and delegates "only&quo= t;.
=A0
I would try to extract the internals from the following methods into n= ew=20 components;
for example, it could look like this;
  • addDocument: component SegementWriter=20
  • addIndexes:=A0 component IndexbasedWriter
What you think? Other ideas / suggestions / tips?
Should I have to send the mail to the lucene mailing list?
=A0
Thx for the feedback
Tim
--f46d042c6b97ac52b104bcf5a2e3--