Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Date: Wed, 18 Apr 2012 17:40:40 +0000 (UTC)
From: "Martijn van Groningen (Commented) (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: 
 <2053084855.1657.1334770840244.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <841031844.855.1334757383612.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (LUCENE-3997) join module should not depend on
 grouping module
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/LUCENE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256740#comment-13256740 ] 

Martijn van Groningen commented on LUCENE-3997:
-----------------------------------------------

+1! Good idea. Maybe we can move FunctionValues and ValueSource from the queries modules to core? Then grouping module doesn't have to depend on the queries module.
                
> join module should not depend on grouping module
> ------------------------------------------------
>
>                 Key: LUCENE-3997
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3997
>             Project: Lucene - Java
>          Issue Type: Task
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>             Fix For: 4.0
>
>         Attachments: LUCENE-3997.patch, LUCENE-3997.patch
>
>
> I think TopGroups/GroupDocs should simply be in core? 
> Both grouping and join modules use these trivial classes, but join depends on grouping just for them.
> I think its better that we try to minimize these inter-module dependencies.
> Of course, another option is to combine grouping and join into one module, but
> last time i brought that up nobody could agree on a name. 
> Anyway I think the change is pretty clean: its similar to having basic stuff like Analyzer.java in core,
> so other things can work with Analyzer without depending on any specific implementing modules.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org