Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A1D239526 for ; Mon, 30 Apr 2012 17:04:10 +0000 (UTC) Received: (qmail 81584 invoked by uid 500); 30 Apr 2012 17:04:09 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 81436 invoked by uid 500); 30 Apr 2012 17:04:09 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 81428 invoked by uid 99); 30 Apr 2012 17:04:09 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Apr 2012 17:04:09 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Apr 2012 17:04:08 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 76B1A428B9A for ; Mon, 30 Apr 2012 17:03:48 +0000 (UTC) Date: Mon, 30 Apr 2012 17:03:48 +0000 (UTC) From: "Michael McCandless (JIRA)" To: dev@lucene.apache.org Message-ID: <1157173298.9834.1335805428487.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1416461157.27342.1330422228474.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (LUCENE-3830) MappingCharFilter could be improved by switching to an FST. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/LUCENE-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-3830: --------------------------------------- Attachment: LUCENE-3830.patch Patch; I think it's basically working. I disallow empty string match to be added (this was accepted, but I think ignored, before), so I had to fix a couple places that were doing that. I also added another random test that separately (slowly) computes the output & corrected offsets and then compares ... it's passing. I still need to do a perf test.. does anyone have a "typical" set of mappings + content I could use? Else I'll try to come up with something... > MappingCharFilter could be improved by switching to an FST. > ----------------------------------------------------------- > > Key: LUCENE-3830 > URL: https://issues.apache.org/jira/browse/LUCENE-3830 > Project: Lucene - Java > Issue Type: Improvement > Reporter: Dawid Weiss > Assignee: Michael McCandless > Priority: Minor > Labels: gsoc2012, lucene-gsoc-12 > Fix For: 4.0 > > Attachments: LUCENE-3830.patch > > > MappingCharFilter stores an overly complex tree-like structure for matching input patterns. The input is a union of fixed strings mapped to a set of fixed strings; an fst matcher would be ideal here and provide both memory and speed improvement I bet. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org