lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Robert Muir <rcm...@gmail.com>
Subject Re: svn commit: r1311110 - /lucene/dev/trunk/modules/analysis/common/src/test/org/apache/lucene/analysis/core/TestRandomChains.java
Date Sun, 08 Apr 2012 22:11:05 GMT
You are right... sorry Uwe

On Sun, Apr 8, 2012 at 6:05 PM, Uwe Schindler <uwe@thetaphi.de> wrote:
> Constructor's param is what it produces, not its parameter. So the code was
> correct, please revert.
>
> Uwe
> --
> Uwe Schindler
> H.-H.-Meier-Allee 63, 28213 Bremen
> http://www.thetaphi.de
>
>
>
> rmuir@apache.org schrieb:
>>
>> Author: rmuir
>> Date: Sun Apr  8 21:56:03 2012
>> New Revision: 1311110
>>
>> URL: http://svn.apache.org/viewvc?rev=1311110&view=rev
>> Log:
>> fix generification bug
>>
>> Modified:
>>
>> lucene/dev/trunk/modules/analysis/common/src/test/org/apache/lucene/analysis/core/TestRandomChains.java
>>
>> Modified:
>> lucene/dev/trunk/modules/analysis/common/src/test/org/apache/lucene/analysis/core/TestRandomChains.java
>> URL:
>> http://svn.apache.org/viewvc/lucene/dev/trunk/modules/analysis/common/src/test/org/apache/lucene/analysis/core/TestRandomChains.java?rev=1311110&r1=1311109&r2=1311110&view=diff
>> ________________________________
>>
>> ---
>> lucene/dev/trunk/modules/analysis/common/src/test/org/apache/lucene/analysis/core/TestRandomChains.java
>> (original)
>> +++
>> lucene/dev/trunk/modules/analysis/common/src/test/org/apache/lucene/analysis/core/TestRandomChains.java
>> Sun Apr  8 21:56:03 2012
>> @@ -190,7 +190,7 @@ public class TestRandomChains extends Ba
>>              // TODO: also look for other variants and handle them special
>>              int idx = random.nextInt(charfilters.size());
>>              try {
>> -              Constructor<? extends CharStream> c =
>> charfilters.get(idx).getConstructor(Reader.class);
>> +              Constructor<? extends Reader> c =
>> charfilters.get(idx).getConstructor(Reader.class);
>>                spec.reader = c.newInstance(spec.reader);
>>              } catch (NoSuchMethodException e) {
>>                Constructor<? extends CharStream> c =
>> charfilters.get(idx).getConstructor(CharStream.class);
>>
>>
>



-- 
lucidimagination.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message