lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (Commented) (JIRA)" <>
Subject [jira] [Commented] (SOLR-3316) Distributed Grouping fails in some scenarios.
Date Fri, 06 Apr 2012 12:01:26 GMT


Robert Muir commented on SOLR-3316:

Some parts of the patch make it difficult to review:
* why does SimpleEndResultTransformer.transform lose its @Override?
* why does GroupedEndResultTransformer/SimpleEndResultTransformer.transform gain an {@inheritDoc}?
I'm not sure this will really do what you expect, because it extends a package-private method
(EndResultTransformer.inheritDoc), which we don't generate javadocs for (only public, protected).

> Distributed Grouping fails in some scenarios.
> ---------------------------------------------
>                 Key: SOLR-3316
>                 URL:
>             Project: Solr
>          Issue Type: Bug
>          Components: SearchComponents - other
>    Affects Versions: 3.4, 3.5
>         Environment: Windows 7, JDK 6u26
>            Reporter: Cody Young
>            Assignee: Martijn van Groningen
>              Labels: distributed, grouping
>         Attachments: SOLR-3316-3x.patch, SOLR-3316.patch,
> During a distributed grouping request, if rows is set to 0 a 500 error is returned.
> If groups are unique to a shard and the row count is set to 1, then the matches number
is only the matches from one shard.
> I've put together a failing test.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message