lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefan Matheis (steffkes) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-3301) Migrate enable/disable Ping from JSP to PingRequestHandler
Date Sat, 21 Apr 2012 14:24:36 GMT

    [ https://issues.apache.org/jira/browse/SOLR-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258861#comment-13258861
] 

Stefan Matheis (steffkes) commented on SOLR-3301:
-------------------------------------------------

Hm, i'm not completely happy with this one. if you're using it w/ the example-configuration,
there is no healthcheck file defined. the ui will indicate a disabled status and if you try
to enable it, it will fail - but w/o any visual notification? 

In addition to that, the Ping Handler is only displaying a {{status: "healthcheck not configured"}}
information, while using a {{200 OK}} Status, can we have something like a {{503 Service Unavailable}}?
To show that it's not "ready" at all?
                
> Migrate enable/disable Ping from JSP to PingRequestHandler
> ----------------------------------------------------------
>
>                 Key: SOLR-3301
>                 URL: https://issues.apache.org/jira/browse/SOLR-3301
>             Project: Solr
>          Issue Type: Improvement
>          Components: web gui
>    Affects Versions: 4.0
>            Reporter: Eric Pugh
>            Assignee: Stefan Matheis (steffkes)
>             Fix For: 4.0
>
>         Attachments: PingRequestHandlerTest.java, health_check_admin_consolidate.patch,
healthcheck-ui.png, healthcheckenable.patch, ping_request_handler.patch
>
>
> My colleague @omnifroodle and I noticed that you can't enable/disable pings in 4.0 because
action.jsp doesn't run.  This patch attaches the functionality to the PingRequestHandler.
 We debated creating a new HealthcheckRequestHandler as well.   We added some basic unit tests.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message