lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dawid Weiss (Commented) (JIRA)" <>
Subject [jira] [Commented] (LUCENE-3973) Incorporate PMD / FindBugs
Date Fri, 13 Apr 2012 06:48:42 GMT


Dawid Weiss commented on LUCENE-3973:

bq. Unless you run into the same taskdef/classloader/sub-build/permgen-OOM

I was just saying to fetch them via ivy and then spawn a separate jvm to run them, much like
you'd do anyway if they are separate installations. 

Besides -- we already have an 'ivy warning with instructions', the same can be done with permgen/OOM
problems -- detect the current (ANT's) VM's settings (can be done via mx bean) and warn/ fail
the build if the defaults are too low, instructing the user to set up ANT_OPTS properly...

I'm not pressing on this, this is a no-issue.
> Incorporate PMD / FindBugs
> --------------------------
>                 Key: LUCENE-3973
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: general/build
>            Reporter: Chris Male
> This has been touched on a few times over the years.  Having static analysis as part
of our build seems like a big win.  For example, we could use PMD to look at {{System.out.println}}
statements like discussed in LUCENE-3877 and we could possibly incorporate the nocommit /
@author checks as well.
> There are a few things to work out as part of this:
> - Should we use both PMD and FindBugs or just one of them? They look at code from different
perspectives (bytecode vs source code) and target different issues.  At the moment I'm in
favour of trying both but that might be too heavy handed for our needs.
> - What checks should we use? There's no point having the analysis if it's going to raise
too many false-positives or problems we don't deem problematic.  
> - How should the analysis be integrated in our build? Need to work out when the analysis
should run, how it should be incorporated in Ant and/or Maven, what impact errors should have.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message