lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3998) facet module should have no dependencies, consolidate examples into demo/
Date Thu, 19 Apr 2012 04:11:07 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257209#comment-13257209
] 

Shai Erera commented on LUCENE-3998:
------------------------------------

I think that having one place for all our examples is a great idea. lucene-demo (or maybe
we rename it to lucene-examples) sounds like the right place.

I took a look at all the nocommit moves, and some are easy to resolve, but others not so easy.
For example:

* FacetsPayloadProcessorProviderTest tests PayloadProcessorProvider, through TaxonomyMergeUtils.
TMU, imo, should remain in examples, but I don't think that we should duplicate its logic
in facet/src/test/. If we move to test to the examples, it will show as if PPP is not tested
by the facets package ...

* MultiCLIndexer/Searcher are good examples of how to create multiple category lists for different
facets. They are used by some facet tests code, even though they have tests of their own,
as utilities to indexing such documents. Duplicating the logic seems wrong to me, and moving
them to facet/src/test is also wrong.

So question -- what's wrong with having tests depend on other modules? None of the facet/src/java
code depends on any module now, but what if facet tests would depend on demo?
                
> facet module should have no dependencies, consolidate examples into demo/
> -------------------------------------------------------------------------
>
>                 Key: LUCENE-3998
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3998
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: modules/facet
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>         Attachments: LUCENE-3998.patch
>
>
> currently facets depends on analyzers-common, but this is unnecessary.
> additionally it has a nice examples/ package (even with javadocs! are they actually seen
anywhere?!),
> as well as tests for those examples.
> I think instead it would be better if facet/ had no dependencies,
> and if examples+examples tests were in demo/.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message