lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-3405) maven artifacts should be equivalent to binary packaging
Date Wed, 25 Apr 2012 14:20:17 GMT

    [ https://issues.apache.org/jira/browse/SOLR-3405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261665#comment-13261665
] 

Robert Muir commented on SOLR-3405:
-----------------------------------

{quote}
So, this time without avoiding the question: why should we not publish solr-core on Maven
Central?
{quote}

Because maven requires that its dependencies are also in maven, whereas the binary distribution
does not:
it exposes its "innards".

Let's talk about how we can make some concrete process on this issue, throwing aside *COMPLETELY*
the whole
.war-third-party-exposure, and the fact that we are releasing as an "application" one way
and as an "api" another way.
Lets just table that for a second, since we will probably end up disagreeing on it anyway
:)

I think the maven artifacts should not be built from the source tree, they should instead
be built from
the binary release (e.g. unzipping the .zip + augmenting with poms). If we build them this
way, this has 
a number of advantages:
# exact same jar files etc are put into the maven/ folder that are in the binary release.
they are just 
  augmented with poms. 
# we can now easily validate, that maven/ folders don't contain anything (besides pom.xmls
etc), that
  aren't found by unzip -l binary release. we can also test that these jar files are exactly
the same.

I think this would be a good, non-controversial step to improving the situation. Such a check
would have
detected the commons-csv situation, no? It also gives us some more faith in the maven artifacts,
since
they are the exact same jar files we are testing in the binary package.

We could do this with lucene, too.

                
> maven artifacts should be equivalent to binary packaging
> --------------------------------------------------------
>
>                 Key: SOLR-3405
>                 URL: https://issues.apache.org/jira/browse/SOLR-3405
>             Project: Solr
>          Issue Type: Task
>          Components: Build
>            Reporter: Robert Muir
>             Fix For: 4.0
>
>
> Lets take the commons-csv scenario: 
> * apache-solr-3.5.0 binary distribution contains no actual commons-csv.jar anywhere,
>   in fact it contains no third party jars (the stuff present in solr/lib) at all.
> * binary distribution contains only the jars necessary for *solrj* and *contrib plugins*,
and a solr.war
> I think the maven artifacts should match whats in the binary release (no third party
jars 
> inside the .war are "exposed", we just publish the .war itself). This exposes a lot less
surface area.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message