lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Male (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (LUCENE-3973) Incorporate PMD / FindBugs
Date Mon, 23 Apr 2012 03:52:45 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-3973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Chris Male updated LUCENE-3973:
-------------------------------

    Attachment: LUCENE-3973.patch

Patch which runs PMD much like RAT.  This uses ivy:cachepath still and I haven't seen any
OOMs.

Since this doesn't have any impact on the build unless someone explicitly runs it, I'd like
to commit this and then begin to tweak.
                
> Incorporate PMD / FindBugs
> --------------------------
>
>                 Key: LUCENE-3973
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3973
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: general/build
>            Reporter: Chris Male
>         Attachments: LUCENE-3973.patch, LUCENE-3973.patch, core.html, solr-core.html
>
>
> This has been touched on a few times over the years.  Having static analysis as part
of our build seems like a big win.  For example, we could use PMD to look at {{System.out.println}}
statements like discussed in LUCENE-3877 and we could possibly incorporate the nocommit /
@author checks as well.
> There are a few things to work out as part of this:
> - Should we use both PMD and FindBugs or just one of them? They look at code from different
perspectives (bytecode vs source code) and target different issues.  At the moment I'm in
favour of trying both but that might be too heavy handed for our needs.
> - What checks should we use? There's no point having the analysis if it's going to raise
too many false-positives or problems we don't deem problematic.  
> - How should the analysis be integrated in our build? Need to work out when the analysis
should run, how it should be incorporated in Ant and/or Maven, what impact errors should have.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message