lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martijn van Groningen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4001) Grouping module shouldn't depend on queries module
Date Sat, 21 Apr 2012 09:28:34 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258817#comment-13258817
] 

Martijn van Groningen commented on LUCENE-4001:
-----------------------------------------------

In think that there are other features that might want to use functions. Faceting by function
or joining by function seem like things that could be added in the future. Question is does
this make functions a core concept? After some thinking it seems to me that functions are
not a core concept. 

What I think is a core concept is the abstraction of a where a values comes from (output of
a function, int from FC or double from doc values). Perhaps this concept should be in core.
The grouping module can use this concept instead of the function concept. This way the grouping
module doesn't need to depend on the queries module. MutableValue is already in core, which
is good. I think for this to happen we need to change FunctionValues.ValueFiller into MutableValueSource
that has the following method:
{code}
public interface MutableValueSource {

   public MutableValue getValue(int doc, MutableValue reuse){
      ...
   }

}
{code}
This also looks similar to how we use FieldCache or DocValues.Source.
                
> Grouping module shouldn't depend on queries module
> --------------------------------------------------
>
>                 Key: LUCENE-4001
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4001
>             Project: Lucene - Java
>          Issue Type: Task
>            Reporter: Martijn van Groningen
>
> Spin off from LUCENE-3997. Basically move FunctionValues and ValueSource to core.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message