lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Male (JIRA)" <>
Subject [jira] [Updated] (SOLR-3402) Parse Version outside of Analysis Factories
Date Tue, 24 Apr 2012 07:05:42 GMT


Chris Male updated SOLR-3402:

    Attachment: SOLR-3402.patch

Finished moving the Version guideline stuff around. Ready for commit in a few days.
> Parse Version outside of Analysis Factories
> -------------------------------------------
>                 Key: SOLR-3402
>                 URL:
>             Project: Solr
>          Issue Type: Improvement
>          Components: Schema and Analysis
>            Reporter: Chris Male
>         Attachments: SOLR-3402.patch, SOLR-3402.patch, SOLR-3402.patch
> Currently the Lucene Version value is put into the Map that is passed to the {{init}}
method of Analysis factories.  During the initialization, the value is parsed and validated.
 In situations where the Core wide value is used, it is converted to a String only for it
to be parsed again.  I think we can improve this, reduce the amount of parsing, and provide
a cleaner separation of concerns.
> Instead the value should be parsed externally and then passed into the Factory.  The
Factory would be responsible for checking that it was given a Version value.  Any additional
validation such as general guidelines about Versions to use, would then fall on code that
passed in the Version to the Factory (namely, FieldPluginLoader).

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message