lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (Created) (JIRA)" <j...@apache.org>
Subject [jira] [Created] (LUCENE-3983) HTMLCharacterEntities.jflex uses String.toUpperCase without Locale
Date Sat, 14 Apr 2012 10:27:17 GMT
HTMLCharacterEntities.jflex uses String.toUpperCase without Locale
------------------------------------------------------------------

                 Key: LUCENE-3983
                 URL: https://issues.apache.org/jira/browse/LUCENE-3983
             Project: Lucene - Java
          Issue Type: Bug
            Reporter: Uwe Schindler
            Assignee: Steven Rowe


Is this expected?

{code:java}
      "xi", "\u03BE", "yacute", "\u00FD", "yen", "\u00A5", "yuml", "\u00FF",
      "zeta", "\u03B6", "zwj", "\u200D", "zwnj", "\u200C"
    };
    for (int i = 0 ; i < entities.length ; i += 2) {
      Character value = entities[i + 1].charAt(0);
      entityValues.put(entities[i], value);
      if (upperCaseVariantsAccepted.contains(entities[i])) {
        entityValues.put(entities[i].toUpperCase(), value);
      }
    }
{code}

In my opinion, this should look like:

{code:java}
      "xi", "\u03BE", "yacute", "\u00FD", "yen", "\u00A5", "yuml", "\u00FF",
      "zeta", "\u03B6", "zwj", "\u200D", "zwnj", "\u200C"
    };
    for (int i = 0 ; i < entities.length ; i += 2) {
      Character value = entities[i + 1].charAt(0);
      entityValues.put(entities[i], value);
      if (upperCaseVariantsAccepted.contains(entities[i])) {
        entityValues.put(entities[i].toUpperCase(Locale.ENGLISH), value);
      }
    }
{code}

(otherwise in the Turkish locale, the entities containing "i" (like "xi" -> '\u03BE') will
not be detected correctly).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message