lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steven Rowe (Commented) (JIRA)" <>
Subject [jira] [Commented] (SOLR-3344) POM dependencies not all there yet for solr-test-framework
Date Tue, 10 Apr 2012 15:39:17 GMT


Steven Rowe commented on SOLR-3344:

bq. I like the optional dependencies alternative better: add optional jetty dependencies to
Solr test-framework, and change the javadoc for BaseDistributedSearchTestCase to note this

Thinking about this more, the rationale I would ordinarily use to justify making a dependency
optional involves minimizing *runtime* dependencies.  But the Solr test-framework is a test-only
module, and requiring *test* dependencies that won't be used by all consumers should not cause
any undue hardship.

So I've changed my mind.  I'll put up a superset of your patch, Benson, that removes the dataimporthandler
and clustering POMs' jetty dependencies.  I'll leave solr-core's optional dependency as-is.
> POM dependencies not all there yet for solr-test-framework
> ----------------------------------------------------------
>                 Key: SOLR-3344
>                 URL:
>             Project: Solr
>          Issue Type: Bug
>          Components: Build
>    Affects Versions: 4.0
>            Reporter: Benson Margulies
>         Attachments: 0001-Add-jetty-deps.patch
> The pom for solr-test-framework does not mention jetty, so a test case that doesn't get
jetty into it's classpath otherwise fails with:
> {noformat}
> java.lang.NoClassDefFoundError: org/eclipse/jetty/server/SessionIdManager
> {noformat}

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message