lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (Commented) (JIRA)" <>
Subject [jira] [Commented] (LUCENE-3969) Use all (non-deprecated) analysis ctors in TestRandomChains
Date Mon, 09 Apr 2012 13:13:28 GMT


Robert Muir commented on LUCENE-3969:

thats nice!

Its still a little bit ugly how the three special cases are handled (and the Sets need to
be kept in sync!), but at least the standard types are created very simple.

Yeah but thats only the exceptional cases, so its no big deal.

I tested the patch, by adding a fake ctor with an unsupported type to BulgarianStemFilter:
public BulgarianStemFilter(final TokenStream input, BitSet ignored) {

Test failed nicely at startup:
[junit] Caused by: java.lang.AssertionError: public,java.util.BitSet)
has unsupported parameter types

Thanks Uwe!

> Use all (non-deprecated) analysis ctors in TestRandomChains
> -----------------------------------------------------------
>                 Key: LUCENE-3969
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: modules/analysis
>            Reporter: Robert Muir
>         Attachments: LUCENE-3969.patch, LUCENE-3969.patch, LUCENE-3969.patch, LUCENE-3969.patch,
LUCENE-3969.patch, LUCENE-3969.patch
> We made TestRandomChains in LUCENE-3919, which reflects all
> analysis components from the classpath and builds analyzers from them,
> then checks consistency.
> but currently it only supports some tokenizers/tokenfilters/charfilters,
> because it hardcodes at certain ctors e.g. Tokenizer(Reader) and Tokenizer(Version+Reader).
> Instead we should use all ctors, just filling them in with random data of
> whatever argument type they take.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message