lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (LUCENE-3967) nuke AtomicReader.termDocsEnum(termState) and termPositionsEnum(termState)
Date Sun, 08 Apr 2012 14:32:18 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Robert Muir updated LUCENE-3967:
--------------------------------

    Attachment: LUCENE-3967.patch
    
> nuke AtomicReader.termDocsEnum(termState) and termPositionsEnum(termState)
> --------------------------------------------------------------------------
>
>                 Key: LUCENE-3967
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3967
>             Project: Lucene - Java
>          Issue Type: Task
>            Reporter: Robert Muir
>         Attachments: LUCENE-3967.patch
>
>
> These are simply sugar methods anyway, and so expert that I don't think we need sugar
here at all.
> If someone wants to get DocsEnum via a saved TermState they can just use TermsEnum!
> But having these public in AtomicReader i think is pretty confusing and overwhelming.
> In fact, nothing in Lucene even uses these methods, except a sole assert statement in
PhraseQuery, 
> which I think can be written more clearly anyway:
> {noformat}
>          // PhraseQuery on a field that did not index
>          // positions.
>          if (postingsEnum == null) {
> -          assert reader.termDocsEnum(liveDocs, t.field(), t.bytes(), state, false) !=
null: "termstate found but no term exists in reader";
> +          assert te.seekExact(t.bytes(), false) : "termstate found but no term exists
in reader";
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message